Skip to content

Commit

Permalink
fix(docker): *-dev tags target right stage from Dockerfile (#27116)
Browse files Browse the repository at this point in the history
  • Loading branch information
lodu authored Feb 15, 2024
1 parent b60938b commit 9514300
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions scripts/build_docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ def get_docker_command(
{cache_to_arg} \\
{build_arg} \\
{platform_arg} \\
{target_argument} \\
--label sha={sha} \\
--label target={build_target} \\
--label build_trigger={build_context} \\
Expand Down
2 changes: 1 addition & 1 deletion tests/unit_tests/scripts/docker_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ def test_get_docker_tags(
SHA,
"push",
"master",
["--load", f"-t {REPO}:master-dev "],
["--load", f"-t {REPO}:master-dev ", "--target dev"],
),
# multi-platform
(
Expand Down

0 comments on commit 9514300

Please sign in to comment.