remove from useEffect

apache · Mar 11, 2021 · bc28498 · bc28498
1 parent c1f70aa
commit bc28498
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
@@ -35,7 +35,6 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
     currentValue,
     inverseSelection,
     inputRef,
-    sortAscending,
   } = formData;
 
   const [values, setValues] = useState<(string | number)[]>(defaultValue ?? []);
@@ -83,7 +82,6 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
     handleChange(currentValue ?? []);
   }, [
     JSON.stringify(currentValue),
-    sortAscending,
     multiSelect,
     enableEmptyFilter,
     inverseSelection,
@@ -93,7 +91,6 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
     handleChange(defaultValue ?? []);
   }, [
     JSON.stringify(defaultValue),
-    sortAscending,
     multiSelect,
     enableEmptyFilter,
     inverseSelection,

diff --git a/superset-frontend/src/filters/components/Select/types.ts b/superset-frontend/src/filters/components/Select/types.ts
@@ -18,9 +18,7 @@
  */
 import {
   Behavior,
-  ChartDataResponseResult,
-  ChartProps,
-  DataRecord, GenericDataType,
+  DataRecord,
   QueryFormData,
   SetDataMaskHook,
 } from '@superset-ui/core';
@@ -41,24 +39,18 @@ export type PluginFilterSelectQueryFormData = QueryFormData &
   PluginFilterStylesProps &
   PluginFilterSelectCustomizeProps;
 
-export interface PluginFilterSelectChartProps extends ChartProps {
-  queriesData: ChartDataResponseResult[];
-}
-
 export type PluginFilterSelectProps = PluginFilterStylesProps & {
-  coltypeMap: Record<string, GenericDataType>;
   data: DataRecord[];
   setDataMask: SetDataMaskHook;
   behaviors: Behavior[];
   formData: PluginFilterSelectQueryFormData;
-  queriesData: ChartDataResponseResult[];
 };
 
 export const DEFAULT_FORM_DATA: PluginFilterSelectCustomizeProps = {
   defaultValue: null,
   currentValue: null,
   enableEmptyFilter: false,
   inverseSelection: false,
-  multiSelect: false,
+  multiSelect: true,
   sortAscending: true,
 };