remove test

apache · Aug 7, 2024 · cc096fe · cc096fe
1 parent 9f320f9
commit cc096fe
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 63 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/superset/config.py b/superset/config.py
@@ -320,6 +320,8 @@ def _try_json_readsha(filepath: str, length: int) -> str | None:
 # ex: http://localhost:8080/swagger/v1
 FAB_API_SWAGGER_UI = True
 
+FAB_ADD_SECURITY_API = True
+
 # ----------------------------------------------------
 # AUTHENTICATION CONFIG
 # ----------------------------------------------------

diff --git a/tests/integration_tests/security/api_tests.py b/tests/integration_tests/security/api_tests.py
@@ -175,7 +175,7 @@ def test_post_security_roles_gamma(self):
     @with_config({"FAB_ADD_SECURITY_API": True})
     def test_put_security_roles_gamma(self):
         """
-        Security API: <TODO>
+        Security API: Gamma shouldnt be able to update roles
         """
         self.login(GAMMA_USERNAME)
         response = self.client.put(
@@ -188,7 +188,7 @@ def test_put_security_roles_gamma(self):
     @with_config({"FAB_ADD_SECURITY_API": True})
     def test_delete_security_roles_gamma(self):
         """
-        Security API: <TODO>
+        Security API: Gamma shouldnt be able to delete roles
         """
         self.login(GAMMA_USERNAME)
         response = self.client.delete(
@@ -197,64 +197,3 @@ def test_delete_security_roles_gamma(self):
             content_type="application/json",
         )
         self.assert403(response)
-
-
-class TestSecurityPermissionsApi(SupersetTestCase):
-    uri = "api/v1/security/permission/"  # noqa: F541
-
-    @with_config({"FAB_ADD_SECURITY_API": True})
-    def test_get_security_roles_admin(self):
-        """
-        Security API: Admin should be able to create roles
-        """
-        self.login(ADMIN_USERNAME)
-        response = self.client.get(self.uri)
-        self.assert200(response)
-
-    @with_config({"FAB_ADD_SECURITY_API": True})
-    def test_get_security_roles_gamma(self):
-        """
-        Security API: Admin should be able to create roles
-        """
-        self.login(GAMMA_USERNAME)
-        response = self.client.get(self.uri)
-        self.assert200(response)
-
-    @with_config({"FAB_ADD_SECURITY_API": True})
-    def test_post_security_roles_gamma(self):
-        """
-        Security API: Gamma shouldnt be able to create roles
-        """
-        self.login(GAMMA_USERNAME)
-        response = self.client.post(
-            self.uri,
-            data=json.dumps({"name": "new_role"}),
-            content_type="application/json",
-        )
-        self.assert403(response)
-
-    # @with_config({"FAB_ADD_SECURITY_API": True})
-    # def test_put_security_roles_gamma(self):
-    #     """
-    #     Security API: <TODO>
-    #     """
-    #     self.login(GAMMA_USERNAME)
-    #     response = self.client.put(
-    #         f"{self.uri}1",
-    #         data=json.dumps({"name": "new_role"}),
-    #         content_type="application/json",
-    #     )
-    #     self.assert403(response)
-
-    # @with_config({"FAB_ADD_SECURITY_API": True})
-    # def test_delete_security_roles_gamma(self):
-    #     """
-    #     Security API: <TODO>
-    #     """
-    #     self.login(GAMMA_USERNAME)
-    #     response = self.client.delete(
-    #         f"{self.uri}1",
-    #         data=json.dumps({"name": "new_role"}),
-    #         content_type="application/json",
-    #     )
-    #     self.assert403(response)