add extra permissions check before loading from cache

superset/config.py

@@ -364,19 +364,22 @@ class CeleryConfig(object):
 # Interval between consecutive polls when using Hive Engine
 HIVE_POLL_INTERVAL = 5
 
-#System to handle delegated data access (Must implement is_allowed_access() which will be called from within superset)
+
+# System to handle delegated data access. Implement both is_allowed_access() and
+# is_eligible_datasource() to delegate access controls.
 class PermsDecider:
-    def __init__(self, ):
+    def __init__(self):
         pass
 
-    def is_eligible_datasource(datasource):
-        #this returns whether or not this perms decider can decide access for this datasource.
+    def is_eligible_datasource(self, datasource):
+        # This returns whether this perms decider can decide access for this datasource.
         return False
 
     def is_allowed_access(self, username, datasource):
-        #returns whether or not the user has access to the datasource.
+        # returns whether or not the user has access to the datasource.
         return False
 
+
 DATA_PERMS_DECIDER = PermsDecider()
 
 try:

superset/viz.py

@@ -20,7 +20,7 @@
 import uuid
 
 from dateutil import relativedelta as rdelta
-from flask import g, escape, request
+from flask import escape, request
 from flask_babel import lazy_gettext as _
 import geohash
 from markdown import markdown
@@ -307,11 +307,7 @@ def get_df_payload(self, query_obj=None):
         cached_dttm = datetime.utcnow().isoformat().split('.')[0]
         if cache_key and cache and not self.force:
             cache_value = cache.get(cache_key)
-            perms_decider = config.get("DATA_PERMS_DECIDER")
-            perms_decider_approves = 
-                not (perms_decider.is_eligible_datasource(self.datasource) and 
-                    perms_decider.is_allowed_access(g.user.username, datasource))
-            if cache_value and perms_decider_approves:
+            if cache_value:
                 stats_logger.incr('loaded_from_cache')
                 try:
                     cache_value = pkl.loads(cache_value)