Skip to content

Commit

Permalink
Improve the chart type of Visualize in sqllab & Add some css & Fix th…
Browse files Browse the repository at this point in the history
…e link address in the navbar
  • Loading branch information
eeve committed Aug 4, 2017
1 parent 4c3313b commit f0c9460
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 8 deletions.
15 changes: 9 additions & 6 deletions superset/assets/javascripts/SqlLab/components/VisualizeModal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,16 @@ import { getExploreUrl } from '../../explore/exploreUtils';
import * as actions from '../actions';
import { VISUALIZE_VALIDATION_ERRORS } from '../constants';
import { QUERY_TIMEOUT_THRESHOLD } from '../../constants';
import visTypes from '../../explore/stores/visTypes';

const CHART_TYPES = [
{ value: 'dist_bar', label: 'Distribution - Bar Chart', requiresTime: false },
{ value: 'pie', label: 'Pie Chart', requiresTime: false },
{ value: 'line', label: 'Time Series - Line Chart', requiresTime: true },
{ value: 'bar', label: 'Time Series - Bar Chart', requiresTime: true },
];
const CHART_TYPES = Object.keys(visTypes).map((typeName) => {
const vis = visTypes[typeName];
return {
value: typeName,
label: vis.label,
requiresTime: !!vis.requiresTime,
};
});

const propTypes = {
actions: PropTypes.object.isRequired,
Expand Down
19 changes: 19 additions & 0 deletions superset/assets/stylesheets/superset.css
Original file line number Diff line number Diff line change
Expand Up @@ -237,3 +237,22 @@ div.widget .slice_container {
.Select-menu-outer {
z-index: 10 !important;
}

/** not found record **/
.panel b {
display: inline-block;
width: 98%;
padding: 2rem;
margin: 0 1% 20px 1%;
background: #f8f8f8;
}

/** table on both sides of the gap **/
.panel .table-responsive{
margin: 0 1%;
}
@media screen and (max-width: 767px) {
.panel .table-responsive{
width: 98%;
}
}
4 changes: 2 additions & 2 deletions superset/templates/appbuilder/navbar.html
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
</a>
</li>
<li>
<a href="https://github.com/airbnb/superset" title="Superset's Github">
<a href="https://github.com/apache/incubator-superset" title="Superset's Github">
<i class="fa fa-github"></i> &nbsp;
</a>
</li>
<li>
<a href="http://airbnb.io/superset" title="Documentation">
<a href="https://superset.incubator.apache.org" title="Documentation">
<i class="fa fa-book"></i> &nbsp;
</a>
</li>
Expand Down

0 comments on commit f0c9460

Please sign in to comment.