Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore][adhoc filter] "use latest_partition" operator disappeared #12752

Closed
3 tasks done
graceguo-supercat opened this issue Jan 25, 2021 · 1 comment · Fixed by #12789
Closed
3 tasks done

[explore][adhoc filter] "use latest_partition" operator disappeared #12752

graceguo-supercat opened this issue Jan 25, 2021 · 1 comment · Fixed by #12789
Labels
#bug:regression Bugs that are identified as regessions explore:filter Related to filters in Explore test:case

Comments

@graceguo-supercat
Copy link

graceguo-supercat commented Jan 25, 2021

in #9637 we added an optional operator for adhoc filter: use latest_partition. It will show up when datasource has single partition. This feature was lost since recent filter redesign work. Note: this feature is not enabled by feature flag. The operator should show up based on the attribute of dataset.

Before

80538611-e4fbf180-895a-11ea-9e72-fbd1ebebb7e1

Current

Screen Shot 2021-01-25 at 1 32 32 PM

How to reproduce the bug

  1. Create a new chart from dataset which has single partition
  2. Check adhoc filter operators
  3. if you can choose use latest_partition, make sure it generate correct custom sql with latest_partition template.

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

cc @junlincc @zuzana-vej

@graceguo-supercat graceguo-supercat added explore:filter Related to filters in Explore #bug Bug report #bug:regression Bugs that are identified as regessions labels Jan 25, 2021
@graceguo-supercat graceguo-supercat changed the title [explore][adhoc filter] "use latest_partition" operator disappeared after redesign [explore][adhoc filter] "use latest_partition" operator disappeared Jan 25, 2021
@junlincc
Copy link
Member

Got it!thanks for reporting and sorry about the regression, we will get to it asap. @graceguo-supercat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions explore:filter Related to filters in Explore test:case
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants