fix(explore): pass partitionColumn when creating new adhoc filter #12789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
reviewed
Jan 27, 2021
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl.jsx
Show resolved
Hide resolved
|
1 nit, other than that LGTM 👍 |
Codecov Report
@@ Coverage Diff @@
## master #12789 +/- ##
==========================================
- Coverage 67.00% 66.79% -0.21%
==========================================
Files 1022 1022
Lines 50049 50047 -2
Branches 4914 5047 +133
==========================================
- Hits 33533 33429 -104
- Misses 16392 16494 +102
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
LGTM |
kgabryje
approved these changes
Jan 27, 2021
villebro
added a commit
that referenced
this pull request
Jan 29, 2021
…2789) * fix(explore): pass partitionColumn when creating new adhoc filter * add default value to state * remove duplicated code * update translations
mistercrunch
added
🍒 1.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The prop
partitionColumnwas not being passed toAdhocFilterPopoverTriggerinaddNewFilterPopoverTriggerofAdhocFilterControl, causing the latest partition operator to be missing for datasources that support it. The override ofvalueRenderseemed to be a leftover from some old time, so it was removed andpartitionColumnadded to the originalvalueRendererthat's created in the constructor. In addition, the operator dropdown showed irrelevant operators, causing the operator count to be inflated. Also fixed a typo ("operators(s)" to "operator(s)") along with relevant translations.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: Partition operator is missing from dropdown. Also notice how the dropdown shows 13 operators, despite only 11 being visible:
After
Partition operator pops up if column supports it. The placeholder is also updated to reflect the new operator count after the column has been selected:
TEST PLAN
ADDITIONAL INFORMATION