Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction of dashboard_rbac broke user_attribute welcome_dashboard_id #13504

Closed
2 of 3 tasks
spookymotion opened this issue Mar 7, 2021 · 1 comment · Fixed by #13505
Closed
2 of 3 tasks

Introduction of dashboard_rbac broke user_attribute welcome_dashboard_id #13504

spookymotion opened this issue Mar 7, 2021 · 1 comment · Fixed by #13505
Labels
dashboard:security:access Related to the security access of the Dashboard

Comments

@spookymotion
Copy link

The method check_dashboard_access tries to access str(kwargs["dashboard_id_or_slug"] which results in a KeyError if the user was redirected from /welcome

Expected results

No KeyError, and user is directed to their welcome_dashboard_id

Actual results

A KeyError

Screenshots

Screen Shot 2021-03-07 at 1 15 19 AM

How to reproduce the bug

Add a row to UserAttribute linking User ID X with welcome_dashboard_id Y

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@spookymotion spookymotion added the #bug Bug report label Mar 7, 2021
@spookymotion
Copy link
Author

Fixed by #13505

@junlincc junlincc removed the #bug Bug report label Mar 8, 2021
@junlincc junlincc mentioned this issue Mar 8, 2021
Merged
6 tasks
@junlincc junlincc added the dashboard:security:access Related to the security access of the Dashboard label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dashboard:security:access Related to the security access of the Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Prevents KeyError in 13504 by making kwarg explicit spookymotion/superset
2 participants
@spookymotion @junlincc