Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevents KeyError in 13504 by making kwarg explicit #13505

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

spookymotion
Copy link

@spookymotion spookymotion commented Mar 7, 2021

SUMMARY

Just made kwarg explicit to prevent KeyError

TEST PLAN

Add a row to UserAttribute linking User ID X with welcome_dashboard_id Y

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

closes #13504

@spookymotion spookymotion changed the title Fixes 13504: KeyError by making kwarg explicit Fix 13504: KeyError by making kwarg explicit Mar 7, 2021
@spookymotion spookymotion changed the title Fix 13504: KeyError by making kwarg explicit Fix 13504: Prevents KeyError by making kwarg explicit Mar 7, 2021
@spookymotion spookymotion changed the title Fix 13504: Prevents KeyError by making kwarg explicit fix 13504: Prevents KeyError by making kwarg explicit Mar 7, 2021
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #13505 (ddf1fda) into master (d0714a0) will increase coverage by 3.47%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13505      +/-   ##
==========================================
+ Coverage   77.41%   80.89%   +3.47%     
==========================================
  Files         909      301     -608     
  Lines       45863    24543   -21320     
  Branches     5534        0    -5534     
==========================================
- Hits        35503    19853   -15650     
+ Misses      10232     4690    -5542     
+ Partials      128        0     -128     
Flag Coverage Δ
cypress ?
hive 80.06% <0.00%> (ø)
javascript ?
mysql 80.39% <0.00%> (ø)
postgres ?
presto 80.09% <0.00%> (-0.01%) ⬇️
python 80.89% <0.00%> (-0.05%) ⬇️
sqlite 80.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.55% <0.00%> (ø)
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/base_api.py 97.79% <0.00%> (-0.45%) ⬇️
superset/db_engine_specs/presto.py 88.03% <0.00%> (-0.43%) ⬇️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx
...end/src/dashboard/components/dnd/DragDroppable.jsx
...t-frontend/src/dashboard/components/SliceAdder.jsx
...tend/src/components/ListView/Filters/DateRange.tsx
superset-frontend/src/views/CRUD/data/common.ts
...ontend/src/explore/components/DataTableControl.tsx
... and 602 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0714a0...ddf1fda. Read the comment docs.

@spookymotion spookymotion changed the title fix 13504: Prevents KeyError by making kwarg explicit fix: Prevents KeyError in 13504 by making kwarg explicit Mar 7, 2021
@junlincc junlincc requested a review from amitmiran137 March 10, 2021 05:06
@junlincc junlincc added the new:contributor The author is a new contributor label Mar 10, 2021
@amitmiran137 amitmiran137 merged commit 226dd4b into apache:master Mar 10, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels new:contributor The author is a new contributor size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduction of dashboard_rbac broke user_attribute welcome_dashboard_id
4 participants