Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gallery] Some chart type in gallery do not have example #16707

Closed
jinghua-qa opened this issue Sep 14, 2021 · 6 comments · Fixed by #26415
Closed

[Gallery] Some chart type in gallery do not have example #16707

jinghua-qa opened this issue Sep 14, 2021 · 6 comments · Fixed by #26415
Labels
good first issue Good first issues for new contributors preset:QA Preset QA team viz:charts:deck.gl Related to deck.gl charts viz:gallery

Comments

@jinghua-qa
Copy link
Member

Some chart type are missing example image in gallery:

Screen Shot 2021-09-14 at 1 56 56 PM

This is the list of chart type that missing example in gallery

Bubble chart
Calendar heatmap
Country map
deck.gl.Arc
deck.gl.Geojson
deck.gl.Grid
deck.gl 3D Hexagon
deck.gl Multiple Layers
deck.gl Path
deck.gl Polygon
deck.gl Scatterplot
deck.gl Screen Grid
Event Flow
Funnel Chart
Gauge Chart
Graph Chart
Mixed Time-Series
Pivot Table v2
Radar Chart
Nightingale Rose Chart
Time-series Table

@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Sep 14, 2021
@junlincc junlincc added the good first issue Good first issues for new contributors label Sep 15, 2021
@junlincc
Copy link
Member

hi community, if you would love to contribute your screenshots of above charts or make a pr to upload those screenshot, we would love to assist :)

@harshalchaudhari35
Copy link

@junlincc Hi, I'd like to contribute to this and take this up. I have been using superset for over a year now so should be able provide various chart screenshots. Although, this is my first OPS to Superset and would like some assistance as to where to put these thumbnails. I had a brief look in the code base but was unable to figure it out.

@junlincc
Copy link
Member

Awesome!! @harshalchaudhari35 really appreciate it. please reach out to me or @villebro @jinghua-qa in slack if you have any questions. Happy to get you up to speed in our codebase.

@junlincc junlincc added the viz:charts:deck.gl Related to deck.gl charts label Nov 17, 2021
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@yash-samsung
Copy link
Contributor

@junlincc @jinghua-qa

Hi,

I see there is no activity for almost last one year on this issue. I would like to contribute to this and take this up as I already have a fix in my local setup for a few chart types. There are currently 32 chart types which are missing example in the gallery. I wanted to know that how should I a raise PR for this - after fixing for all the 32 chart types in a single PR? or one chart type in a PR?

I would prefer to have single PR for one chart type as this way PR size would be small and would be easier to review compared to fixing all chart types in one single PR. Please let me know your thoughts.

@Shazad-khan
Copy link

image

This issue has been already addressed

sivasathyaseeelan added a commit to sivasathyaseeelan/superset that referenced this issue Jan 1, 2024
josedev-union pushed a commit to Ortege-xyz/studio that referenced this issue Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issues for new contributors preset:QA Preset QA team viz:charts:deck.gl Related to deck.gl charts viz:gallery
Projects
None yet
5 participants