Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select component fires onChange when selected value has not changed #27668

Closed
3 tasks done
fisjac opened this issue Mar 26, 2024 · 0 comments · Fixed by #27706
Closed
3 tasks done

Select component fires onChange when selected value has not changed #27668

fisjac opened this issue Mar 26, 2024 · 0 comments · Fixed by #27706
Assignees

Comments

@fisjac
Copy link
Contributor

fisjac commented Mar 26, 2024

Bug description

When rendering the Select component in singleMode (only one selection can be selected), selecting the currently selected value from the dropdown options triggers the onChange function to fire, even though the selection has not changed.

How to reproduce the bug

Go to alerts and reports
Add an alert or report
Under notification settings, select Email
Add some text to the recipients section
Select Email again
See that the recipients field has been cleared

Screenshots/recordings

https://www.loom.com/share/9f9829e8877a444db074e6f8ce0f669f?sid=1e4fe88d-4075-4b6a-9dc0-50749316baa2

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

ALERT_REPORTS=True

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants