Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AlertReports): preventing reset of notification settings when method does not change #27556

Closed
wants to merge 1 commit into from

Conversation

fisjac
Copy link
Contributor

@fisjac fisjac commented Mar 18, 2024

SUMMARY

When selecting a method for notification settings in the alerts and reports modal, the notification settings are deleted when the same method is selected. This PR addresses this issue by preventing an update to the notificationSettings when no the method value has not changed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
https://www.loom.com/share/9f9829e8877a444db074e6f8ce0f669f?sid=1e4fe88d-4075-4b6a-9dc0-50749316baa2

After:
https://www.loom.com/share/906d409dfbd14d56ab2e4e0ee0f1c799?sid=8464d755-954b-4787-a9d1-4942258b2f49

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: ALERT_REPORTS
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.44%. Comparing base (ae29427) to head (1c9def4).
Report is 5 commits behind head on master.

Files Patch % Lines
.../features/alerts/components/NotificationMethod.tsx 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27556      +/-   ##
==========================================
+ Coverage   67.36%   67.44%   +0.07%     
==========================================
  Files        1909     1910       +1     
  Lines       74744    74799      +55     
  Branches     8329     8346      +17     
==========================================
+ Hits        50352    50446      +94     
+ Misses      22342    22301      -41     
- Partials     2050     2052       +2     
Flag Coverage Δ
javascript 57.38% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley requested a review from eschutho March 19, 2024 17:25
@fisjac fisjac closed this Mar 26, 2024
@fisjac
Copy link
Contributor Author

fisjac commented Mar 26, 2024

Closing in favor of another PR to address upstream issue #27668

@fisjac
Copy link
Contributor Author

fisjac commented Mar 28, 2024

Resolved in the following PR:
#27668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants