Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table config] Add SQL query editor functions in SQL Expression box #5417

Closed
3 tasks
vylc opened this issue Jul 17, 2018 · 6 comments
Closed
3 tasks

[Table config] Add SQL query editor functions in SQL Expression box #5417

vylc opened this issue Jul 17, 2018 · 6 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community good first issue Good first issues for new contributors .pinned Draws attention

Comments

@vylc
Copy link

vylc commented Jul 17, 2018

Just killed myself trying to edit my SQL formula for a metric in the SQL expression box. Would be really helpful to have the syntax checking/linting/autocompletes of columns from the table - especially with end quotes and parentheses in this box.

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

Expected results

Actual results

Steps to reproduce
@vylc vylc added the enhancement:request Enhancement request submitted by anyone from the community label Mar 11, 2019
@stale
Copy link

stale bot commented May 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 10, 2019
@stale stale bot closed this as completed May 17, 2019
@mistercrunch mistercrunch added the .pinned Draws attention label May 17, 2019
@mistercrunch mistercrunch reopened this May 17, 2019
@stale stale bot removed the inactive Inactive for >= 30 days label May 17, 2019
@IndexOutOfRange
Copy link

Not sure if this issue is still relevant as, in the sql editor, there are:

  • autocomplete on a lot of stuff
  • auto end quotes
  • auto closing parenthesis

and various others. Am I missing something ?

@mistercrunch
Copy link
Member

mistercrunch commented Feb 10, 2020 •
edited
Loading

I think this refers to the SQL Expression box(es), either in the "table editor" or the "metric editor" in the explore view. Also would be great to have a "validate" button that makes sure that you can run a SELECT {expression} FROM {table} LIMIT 1 or similar

@IndexOutOfRange
Copy link

Not sure if the original issue was about the the boxes in the new edit datasource react UI popup or the legacy edit datasources jinja form.

The issue seems older than the creation of the react popup but i am unable to assess how frequently the legacy UI is still in use.

IndexOutOfRange added a commit to IndexOutOfRange/incubator-superset that referenced this issue Feb 17, 2020
@IndexOutOfRange
Add Test SQL Button fix issue apache#5417
acb2629
IndexOutOfRange added a commit to IndexOutOfRange/incubator-superset that referenced this issue Feb 17, 2020
@IndexOutOfRange
Add Test SQL Button fix issue apache#5417
0863377 
use of sql_json endpoint

handles database_id

not easy to get on column view

Add Test SQL Button fix issue apache#5417
IndexOutOfRange added a commit to IndexOutOfRange/incubator-superset that referenced this issue Feb 17, 2020
@IndexOutOfRange
Add Test SQL Button fix issue apache#5417
65cb6c2
@IndexOutOfRange IndexOutOfRange mentioned this issue Feb 24, 2020
Closed
12 tasks
@mistercrunch mistercrunch added the good first issue Good first issues for new contributors label Sep 18, 2020
@junlincc
Copy link
Member

@yousoph related to SQL Expression Validator component project

@betodealmeida betodealmeida mentioned this issue Apr 21, 2021
Closed
3 tasks
@betodealmeida
Copy link
Member

Moved this to #12899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement:request Enhancement request submitted by anyone from the community good first issue Good first issues for new contributors .pinned Draws attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Explore] Add Test SQL button to table explore view IndexOutOfRange/incubator-superset
5 participants
@mistercrunch @betodealmeida @IndexOutOfRange @vylc @junlincc