Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong "backquotes" around datasource when "Explorer in SQL Lab" from a Chart #8178

Closed
squalou opened this issue Sep 5, 2019 · 5 comments · Fixed by #8181
Closed

wrong "backquotes" around datasource when "Explorer in SQL Lab" from a Chart #8178

squalou opened this issue Sep 5, 2019 · 5 comments · Fixed by #8181
Labels
!deprecated-label:bug Deprecated label - Use #bug instead v0.34

Comments

@squalou
Copy link
Contributor

squalou commented Sep 5, 2019

From a Chart editor using a datasource, when clicking on 'datasource' then choosing 'explore in SQL Lab', the query filled in SQLLab contains wrong chars around datasource name.

Expected results

for instance : SQL Lab should contain select * from schema.table limite 100

Actual results

select * from `schema.table` limite 100

=> this causes the query to fail.

Screenshots

2019-09-05 11-13-49 screenshot

How to reproduce the bug

  1. Go to any chart based no a table datasource
  2. Click on datasource
  3. Scroll to "ezxplore in SQL Lab"
  4. See error

Environment

(please complete the following information):

  • superset version: 0.34 and master HEAD from 2019-08-27
  • python version: 3.6
  • node.js version: 12.9.0

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • [x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x ] I have reproduced the issue with at least the latest released version of superset.
  • [x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.99. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 5, 2019
@villebro villebro added the v0.34 label Sep 5, 2019
@squalou
Copy link
Contributor Author

squalou commented Sep 11, 2019

PLZ IGNORE THIS POST I WAS MISTAKEN

I must be missing something.
With the same test case, now I get these errors. But no table at all....

image

@villebro
Copy link
Member

Very strange, I double checked that everything is working properly for me on master. Can you redo all steps, verify that the datasource still exists and post the steps here so I can verify I'm not doing something differently.

@squalou
Copy link
Contributor Author

squalou commented Sep 13, 2019

Daaammn ! sorry
I was pretty sure I deleted this post.

After another full check, It was an issue on my side, incorrect docker build / deploy.

It's fixed.

Deeply sorry.

@villebro
Copy link
Member

No sweat @squalou ! Double checking this actually uncovered another unrelated issue, so net positive false positive 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead v0.34
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants