[bugfix] Correctly quote table and schema in select_star #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
changed the title
|
@villebro would you mind adding a unit test? |
john-bodley
reviewed
Sep 5, 2019
tests/model_tests.py
Outdated
| @@ -126,6 +126,28 @@ def test_select_star(self): | |||
| ) | |||
| assert sql.startswith(expected) | |||
|
|
|||
| def test_select_star_with_exotic_names(self): | |||
| main_db = get_example_database() | |||
There was a problem hiding this comment.
@villebro I'm not overly familiar with the new example database but I gather the engine is related to the tox environment, i.e., py36-mysql, py35-sqlite, etc.
There was a problem hiding this comment.
It's my understanding that the example db falls back to SQLALCHEMY_DATABASE_URI if SQLALCHEMY_EXAMPLES_URI is undefined, i.e. it should test all engines that have a tox env.
john-bodley
approved these changes
Sep 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #8181 +/- ##
=========================================
- Coverage 73.75% 66.2% -7.56%
=========================================
Files 115 479 +364
Lines 12053 22930 +10877
Branches 0 2524 +2524
=========================================
+ Hits 8890 15181 +6291
- Misses 3163 7615 +4452
- Partials 0 134 +134
Continue to review full report at Codecov.
|
mistercrunch
added
🍒 0.34.1
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Fix select_star table quoting bug * Add unit test for fully qualified names in select_star * Rename main_db to db * Rename test function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
When clicking
Explore in SQL Labfrom a chart, datasources with a schema are quoted incorrectly.TEST PLAN
Tested locally
ADDITIONAL INFORMATION
REVIEWERS
@squalou @mistercrunch @john-bodley