chore: Upgrade pylint to 2.5.3 and fix most new rules #10101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 17, 2020 19:57
This was referenced Jun 18, 2020
|
Woohoo! Clean build! |
|
NICE! cc @john-bodley |
|
Squeaky clean build! |
|
Mergin' before it conflicts with any of the 40 files it touches! |
|
Thanks @willbarrett. So happy to see people chipping away at fixing |
This was referenced Jun 19, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Bump pylint version to 2.5.3 * Add a global disable for the most common new pylint error * Fix a bunch of files containing very few errors * More pylint tweakage, low-hanging fruit * More easy stuff... * Fix more erroring files * Fix the last couple of errors, clean pylint! * Black * Fix mypy issue in connectors/druid/models.py
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bumps pylint to 2.5.3, fixes most of the new checks, disables one new check that would keep us from working around circular import issues that we have right now.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
n/a
TEST PLAN
Rely on CI
ADDITIONAL INFORMATION
Reviewers
@john-bodley @mistercrunch @craig-rueda