Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change "add new slice" page title copy to "add new chart" #10457

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Jul 28, 2020

SUMMARY

Pretty much what the title says. Updates page title for adding a chart to better match its content.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
Screen Shot 2020-07-28 at 2 35 43 PM

After
Screen Shot 2020-07-28 at 2 35 27 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

Codecov Report

Merging #10457 into master will increase coverage by 6.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10457      +/-   ##
==========================================
+ Coverage   64.29%   70.37%   +6.08%     
==========================================
  Files         544      604      +60     
  Lines       30586    32381    +1795     
  Branches     2885     3272     +387     
==========================================
+ Hits        19665    22788    +3123     
+ Misses      10743     9483    -1260     
+ Partials      178      110      -68     
Flag Coverage Δ
#cypress 54.80% <ø> (-0.31%) ⬇️
#javascript 59.16% <ø> (?)
#python 69.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/setup/setupPlugins.ts 22.22% <0.00%> (-77.78%) ⬇️
superset-frontend/src/SqlLab/index.tsx 25.00% <0.00%> (-75.00%) ⬇️
...rset-frontend/src/setup/setupErrorMessagesExtra.ts 50.00% <0.00%> (-50.00%) ⬇️
superset-frontend/src/setup/setupErrorMessages.ts 55.55% <0.00%> (-44.45%) ⬇️
superset-frontend/src/preamble.ts 56.52% <0.00%> (-24.73%) ⬇️
...s/ErrorMessage/getErrorMessageComponentRegistry.ts 85.71% <0.00%> (-14.29%) ⬇️
...et-frontend/src/components/RefreshChartOverlay.tsx 90.00% <0.00%> (-10.00%) ⬇️
.../src/components/Select/WindowedSelect/windowed.tsx 94.11% <0.00%> (-5.89%) ⬇️
superset-frontend/src/setup/setupApp.ts 25.00% <0.00%> (-3.58%) ⬇️
...rc/components/ErrorMessage/TimeoutErrorMessage.tsx 5.45% <0.00%> (-1.22%) ⬇️
... and 221 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9914ae1...01736f2. Read the comment docs.

@nytai nytai merged commit c716f7a into apache:master Jul 29, 2020
@nytai nytai deleted the moriah/add-new-chart branch July 29, 2020 01:28
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants