fix: refactored SQL-based alerts to not pass sqlalchemy objects as args #10506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
reviewed
Aug 3, 2020
superset/tasks/schedules.py
Outdated
| return | ||
|
|
||
| if run_alert_query(schedule): | ||
| if run_alert_query( | ||
| schedule.id, |
There was a problem hiding this comment.
Instead of passing in every param needed from schedule, maybe it's cleaner to only pass in the schedule id, then you can get the schedule object within the function and reference all the params there.
bkyryliuk
approved these changes
Aug 4, 2020
bkyryliuk
reviewed
Aug 4, 2020
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
…gs (apache#10506) * refractored alerting to not pass sqlalchemy obj as args * updated to pass only alert id as arg * used object id instead of argument * updated alerts_tests.py to reflect change Co-authored-by: Jason Davis <@dropbox.com>
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…gs (apache#10506) * refractored alerting to not pass sqlalchemy obj as args * updated to pass only alert id as arg * used object id instead of argument * updated alerts_tests.py to reflect change Co-authored-by: Jason Davis <@dropbox.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updated the code for SQL-based alerting to remove the passing of sqlalchemy objects as arguments to functions and instead replace them with ids for those objects.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION