Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reword and cleanup docs for local dev server #11869

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Dec 1, 2020

SUMMARY

Cleanup the docs for frontend development a little bit. Highlight the --superset option for npm run dev-server.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #11869 (2bee4b5) into master (9acf48f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11869   +/-   ##
=======================================
  Coverage   62.83%   62.83%           
=======================================
  Files        1014     1014           
  Lines       49489    49489           
  Branches     5073     5073           
=======================================
  Hits        31095    31095           
  Misses      18184    18184           
  Partials      210      210           
Flag Coverage Δ
javascript 60.71% <ø> (ø)
python 64.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9acf48f...2bee4b5. Read the comment docs.

@ktmud ktmud force-pushed the frontend-contribution-doc branch 2 times, most recently from 7a83f25 to 8bd612d Compare December 6, 2020 05:00
@@ -436,40 +439,40 @@ cd superset-frontend
npm ci
```

#### Building
#### Build assets
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is the only part that has been updated.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud ktmud force-pushed the frontend-contribution-doc branch from 8bd612d to adf9949 Compare December 8, 2020 23:26
@ktmud ktmud force-pushed the frontend-contribution-doc branch from adf9949 to 2bee4b5 Compare January 11, 2021 01:37
@ktmud ktmud merged commit ff7b789 into master Jan 11, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
@amitmiran137 amitmiran137 deleted the frontend-contribution-doc branch March 29, 2021 18:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants