-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refetch samples on Explore view only when filters change #11999
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11999 +/- ##
==========================================
- Coverage 66.74% 63.53% -3.22%
==========================================
Files 942 466 -476
Lines 45834 28682 -17152
Branches 4400 0 -4400
==========================================
- Hits 30592 18222 -12370
+ Misses 15114 10460 -4654
+ Partials 128 0 -128
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
closes #11968 |
Tested - no refetch data when doing different operation than filtering (left side of explore view). OK! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
This PR optimizes fetching samples. The goal is not to refetch on every change in controls panel, but only when filters change, because only filters affect the response of samples endpoint.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Verify that we refetch samples only when filters change either in Networking tab of browser console or visually, by seeing that there's no spinner that indicates fetching data.
ADDITIONAL INFORMATION
CC: @mistercrunch @rusackas @junlincc @adam-stasiak