[WIP] chore(explore): remove dedicated time section #12147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12147 +/- ##
==========================================
- Coverage 67.15% 63.29% -3.87%
==========================================
Files 994 484 -510
Lines 49033 29744 -19289
Branches 4977 0 -4977
==========================================
- Hits 32929 18825 -14104
+ Misses 15982 10919 -5063
+ Partials 122 0 -122
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
force-pushed
the
explore-control-ui
branch
from
7a00893 to
3b4fe7e
Compare
simcha90
reviewed
Dec 20, 2020
| datasourceType === 'table' ? sqlaTimeSeries : druidTimeSeries; | ||
| const { datasourceAndVizType } = sections; | ||
| // list of datasource-specific controls that should be removed | ||
| const invalidControls = |
There was a problem hiding this comment.
I saw in attached PR apache-superset/superset-ui#869 also time_range, shouldn't be it here, or is it single valid time control?
There was a problem hiding this comment.
time_range is the exception to the rule, as it should always be available (this will be noved to the forthcoming Filters section).
6 tasks
ktmud
added a commit
to ktmud/superset
that referenced
this pull request
Dec 23, 2020
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 7, 2021
…configs (apache#12091) * Clean up queryFields * Clean up unused vars * Bump chart plugins * Bringing changes in apache#12147
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 7, 2021
…configs (apache#12091) * Clean up queryFields * Clean up unused vars * Bump chart plugins * Bringing changes in apache#12147
This was referenced Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This makes it possible to remove the dedicated time section. Requires the release of
superset-uito introduce these breaking changes: apache-superset/superset-ui#869 . The visual changes will be introduced in forthcoming PRs.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Non timeseries chart:
Timeseries chart:
TEST PLAN
ADDITIONAL INFORMATION