Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate DashboardFilter class and change imports accordingly #12405

Merged

Conversation

amitmiran137
Copy link
Member

SUMMARY

there was duplicate code so removed the filter.py and changed imports

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #12405 (4a0cf5d) into master (f13f2e2) will decrease coverage by 4.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12405      +/-   ##
==========================================
- Coverage   66.88%   62.81%   -4.07%     
==========================================
  Files        1014     1013       -1     
  Lines       49528    49474      -54     
  Branches     5074     5077       +3     
==========================================
- Hits        33125    31078    -2047     
- Misses      16273    18186    +1913     
- Partials      130      210      +80     
Flag Coverage Δ
cypress ?
javascript 60.71% <ø> (+0.01%) ⬆️
python 64.19% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/chart/mixin.py 100.00% <100.00%> (ø)
superset/views/dashboard/mixin.py 95.00% <100.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/filters/components/Select/types.ts 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13f2e2...4a0cf5d. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@villebro villebro requested a review from dpgaspar January 14, 2021 11:04
@villebro villebro merged commit ec0e872 into apache:master Jan 14, 2021
amitmiran137 added a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
…rdingly (apache#12405)

* chore: remove duplicate DashboardFilter class and change imports accordingly

* fix: pre-commit isort issue
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants