-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): fixed table header in chrome #12432
Conversation
👀 you're opening PRs now?! 👏 Can you confirm this hasn't affected the other list views, they're using the same table component. |
Codecov Report
@@ Coverage Diff @@
## master #12432 +/- ##
==========================================
- Coverage 66.81% 63.51% -3.30%
==========================================
Files 1015 486 -529
Lines 49538 29895 -19643
Branches 5079 0 -5079
==========================================
- Hits 33097 18988 -14109
+ Misses 16311 10907 -5404
+ Partials 130 0 -130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yup 3rd already, check out the other two one line change(with 5 commits) PRs 😅🤦🏾♀️ #12402 #12392 |
Code looks fine 😄 . I have a bunch of other stuff running at the moment and it's hard to switch over to superset, but I'll test once i'm done with my current setup |
Tested it is ok. I found an issue with scrolling on Safari but not related to this change. I will raise it in another issue :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SUMMARY
this pr is to FIX table header in Explore Data section
closes #12430
BEFORE
AFTER
cc @kgabryje @ktmud
TEST PLAN
ADDITIONAL INFORMATION