Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: sqlite db engine spec #12616

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Conversation

kstrz
Copy link
Contributor

@kstrz kstrz commented Jan 20, 2021

SUMMARY

Increase coverage for sqlite db engine spec

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@kstrz
Copy link
Contributor Author

kstrz commented Jan 20, 2021

Hey! Could you look at it? @willbarrett @dpgaspar

@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #12616 (124685c) into master (a422c76) will decrease coverage by 3.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12616      +/-   ##
==========================================
- Coverage   66.79%   63.42%   -3.38%     
==========================================
  Files        1015      486     -529     
  Lines       49676    29984   -19692     
  Branches     4847        0    -4847     
==========================================
- Hits        33183    19017   -14166     
+ Misses      16371    10967    -5404     
+ Partials      122        0     -122     
Flag Coverage Δ
cypress ?
javascript ?
python 63.42% <ø> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/db_engine_specs/presto.py 70.56% <0.00%> (-11.48%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/db_engine_specs/mysql.py 89.79% <0.00%> (-2.05%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/result_set.py 96.69% <0.00%> (-1.66%) ⬇️
superset/models/core.py 87.22% <0.00%> (-1.64%) ⬇️
superset/db_engine_specs/base.py 85.20% <0.00%> (-0.77%) ⬇️
superset/views/core.py 74.85% <0.00%> (-0.45%) ⬇️
... and 531 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a422c76...124685c. Read the comment docs.

@dpgaspar dpgaspar merged commit 0de61df into apache:master Jan 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants