Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: elizabeth/revert infra reviewer updates #12698

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Jan 22, 2021

SUMMARY

This PR is reverts #12694 and is only preemptive in case the original PR changes anything unexpectedly and we want to go back to the original settings.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho marked this pull request as draft January 22, 2021 21:59
@codecov-io
Copy link

Codecov Report

Merging #12698 (8f4a9e6) into master (c85b4c7) will decrease coverage by 3.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12698      +/-   ##
==========================================
- Coverage   66.81%   63.36%   -3.45%     
==========================================
  Files        1017      487     -530     
  Lines       49734    30014   -19720     
  Branches     4864        0    -4864     
==========================================
- Hits        33229    19018   -14211     
+ Misses      16382    10996    -5386     
+ Partials      123        0     -123     
Flag Coverage Δ
cypress ?
javascript ?
python 63.36% <0.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/connectors/sqla/models.py 84.31% <0.00%> (-6.28%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.59% <0.00%> (-3.27%) ⬇️
superset/databases/api.py 89.49% <0.00%> (-2.53%) ⬇️
... and 547 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85b4c7...8f4a9e6. Read the comment docs.

@eschutho
Copy link
Member Author

I'm going to rebase this with master once #12694 lands

@eschutho eschutho force-pushed the elizabeth/revert-infra-reviewer-updates branch from 8f4a9e6 to 5c30d9d Compare January 22, 2021 23:48
@amitmiran137
Copy link
Member

you draft it!! nice :)

@eschutho eschutho closed this Jan 27, 2021
@eschutho
Copy link
Member Author

we've decided that a revert actually won't work on this PR since the merge will be blocked.

@eschutho eschutho deleted the elizabeth/revert-infra-reviewer-updates branch February 27, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants