-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rm grace period field for reports modal #12800
fix: rm grace period field for reports modal #12800
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12800 +/- ##
==========================================
- Coverage 67.00% 59.19% -7.82%
==========================================
Files 1022 965 -57
Lines 50105 47304 -2801
Branches 5191 4440 -751
==========================================
- Hits 33572 28000 -5572
- Misses 16402 19304 +2902
+ Partials 131 0 -131
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green.
653d5a6
to
b7a779c
Compare
(cherry picked from commit 5719fef)
b7a779c
to
ce40788
Compare
hmm, what's up with the |
Gah! GH had it collapsed and I didn't notice - good catch @nytai |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION