Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm grace period field for reports modal #12800

Merged

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Jan 27, 2021

SUMMARY

  • Only show 'grace period' input field for alerts
  • Minor styling fix for dropdown widths

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-01-27 at 3 19 14 PM

TEST PLAN

  • Update modal spec file

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #12800 (ce40788) into master (a0e05a5) will decrease coverage by 7.81%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12800      +/-   ##
==========================================
- Coverage   67.00%   59.19%   -7.82%     
==========================================
  Files        1022      965      -57     
  Lines       50105    47304    -2801     
  Branches     5191     4440     -751     
==========================================
- Hits        33572    28000    -5572     
- Misses      16402    19304    +2902     
+ Partials      131        0     -131     
Flag Coverage Δ
cypress 50.91% <0.00%> (-0.01%) ⬇️
javascript ?
python 63.90% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 4.43% <0.00%> (-42.33%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/nativeFilters/ScopingTree.tsx 6.25% <0.00%> (-93.75%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 11.76% <0.00%> (-88.24%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
superset-frontend/src/components/IconTooltip.tsx 13.33% <0.00%> (-86.67%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
... and 399 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e05a5...ce40788. Read the comment docs.

Copy link
Member

@willbarrett willbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green.

@riahk riahk force-pushed the moriah/alert-report-grace-period-fix branch from 653d5a6 to b7a779c Compare January 28, 2021 18:45
@riahk riahk closed this Jan 28, 2021
@riahk riahk reopened this Jan 28, 2021
@riahk riahk force-pushed the moriah/alert-report-grace-period-fix branch from b7a779c to ce40788 Compare January 28, 2021 22:27
@willbarrett willbarrett merged commit fa8c492 into apache:master Jan 28, 2021
@willbarrett willbarrett deleted the moriah/alert-report-grace-period-fix branch January 28, 2021 23:17
@nytai
Copy link
Member

nytai commented Jan 28, 2021

hmm, what's up with the CHANGELOG.md changes? Was that intentional?

@willbarrett
Copy link
Member

Gah! GH had it collapsed and I didn't notice - good catch @nytai

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XL 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants