-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Presto column_type_mappings time and timestamp #12861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
reviewed
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Would you mind adding a unit test for this?
superset/tests/db_engine_specs/presto_tests.py
Lines 537 to 558 in 9a7fba8
def test_get_sqla_column_type(self): | |
sqla_type = PrestoEngineSpec.get_sqla_column_type("varchar(255)") | |
assert isinstance(sqla_type, types.VARCHAR) | |
assert sqla_type.length == 255 | |
sqla_type = PrestoEngineSpec.get_sqla_column_type("varchar") | |
assert isinstance(sqla_type, types.String) | |
assert sqla_type.length is None | |
sqla_type = PrestoEngineSpec.get_sqla_column_type("char(10)") | |
assert isinstance(sqla_type, types.CHAR) | |
assert sqla_type.length == 10 | |
sqla_type = PrestoEngineSpec.get_sqla_column_type("char") | |
assert isinstance(sqla_type, types.CHAR) | |
assert sqla_type.length is None | |
sqla_type = PrestoEngineSpec.get_sqla_column_type("integer") | |
assert isinstance(sqla_type, types.Integer) | |
sqla_type = PrestoEngineSpec.get_sqla_column_type(None) | |
assert sqla_type is None |
villebro
approved these changes
Feb 1, 2021
villebro
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Fix presto column_type_mappings time and timestamp * Added unit tests
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Feb 2, 2021
* Fix presto column_type_mappings time and timestamp * Added unit tests
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Presto has incorrect order of column type mappings.
timestamp
is overriden withtime
due to these lines:causing incorrect query statement to be passed from superset to presto.
TEST PLAN
Proposed solutions swaps those lines.
ADDITIONAL INFORMATION