fix(database): ensure pk_constraint is JSON serializable #13147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some databases return sets in the dict payload (they should be lists according to the docs) when calling
inspector.get_pk_constraint
which doesn't serialize to JSON. In addition, an empty set evaluates to truthy vs lists that evaluate to falsy, causing trouble downstream. By normalizing to JSON serializable datatypes we ensure that the response for the external metadata endpoint will return a valid response.TEST PLAN
Local testing
ADDITIONAL INFORMATION