-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filter-sets): Saving filter sets in metadata #13205
Conversation
� Conflicts: � superset-frontend/src/featureFlags.ts � superset/config.py
…meta � Conflicts: � superset-frontend/src/dashboard/actions/nativeFilters.ts � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx � superset-frontend/src/dashboard/reducers/nativeFilters.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works like a charm!
Codecov Report
@@ Coverage Diff @@
## master #13205 +/- ##
===========================================
+ Coverage 53.06% 71.51% +18.45%
===========================================
Files 489 766 +277
Lines 17314 40100 +22786
Branches 4482 4088 -394
===========================================
+ Hits 9187 28676 +19489
- Misses 8127 11424 +3297
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
This pr add feature to save filters sets in metadata and remove them from there. Also here fixed relevant bug that sometimes dashboard is updated when non-instant filter changed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-02-18.at.12.51.11.mov
TEST PLAN
ADDITIONAL INFORMATION