Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter-sets): Saving filter sets in metadata #13205

Merged
merged 12 commits into from
Feb 18, 2021

Conversation

simcha90
Copy link
Contributor

SUMMARY

This pr add feature to save filters sets in metadata and remove them from there. Also here fixed relevant bug that sometimes dashboard is updated when non-instant filter changed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-02-18.at.12.51.11.mov

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works like a charm!

@codecov-io
Copy link

codecov-io commented Feb 18, 2021

Codecov Report

Merging #13205 (29d0f24) into master (2ce7982) will increase coverage by 18.45%.
The diff coverage is 72.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13205       +/-   ##
===========================================
+ Coverage   53.06%   71.51%   +18.45%     
===========================================
  Files         489      766      +277     
  Lines       17314    40100    +22786     
  Branches     4482     4088      -394     
===========================================
+ Hits         9187    28676    +19489     
- Misses       8127    11424     +3297     
Flag Coverage Δ
cypress 58.42% <68.22%> (+5.36%) ⬆️
python 80.12% <80.24%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/ResultSet.tsx 4.16% <0.00%> (-0.09%) ⬇️
...end/src/SqlLab/components/RunQueryActionButton.tsx 52.77% <ø> (ø)
superset-frontend/src/chart/ChartContainer.jsx 100.00% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx 75.67% <0.00%> (-1.04%) ⬇️
...perset-frontend/src/common/components/Dropdown.tsx 50.00% <ø> (ø)
...t-frontend/src/common/components/Tooltip/index.tsx 100.00% <ø> (ø)
...perset-frontend/src/components/AlteredSliceTag.jsx 92.00% <ø> (ø)
superset-frontend/src/components/CachedLabel.jsx 42.10% <ø> (ø)
...ontend/src/components/CertifiedIconWithTooltip.tsx 0.00% <ø> (ø)
...perset-frontend/src/components/CopyToClipboard.jsx 57.14% <0.00%> (ø)
... and 465 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85497e...29d0f24. Read the comment docs.

@villebro villebro merged commit 2ff8741 into apache:master Feb 18, 2021
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Mar 12, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants