test: FormLabel dedicated directory and tests #13270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13270 +/- ##
===========================================
- Coverage 72.29% 62.20% -10.10%
===========================================
Files 864 567 -297
Lines 44883 20665 -24218
Branches 5403 5421 +18
===========================================
- Hits 32450 12854 -19596
+ Misses 12224 7602 -4622
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks for the PR! this project is progressing so nicely, thanks to you all @geido @michael-s-molina @yardz 🙏
|
michael-s-molina
approved these changes
Feb 23, 2021
rusackas
approved these changes
Mar 1, 2021
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* Form label directory and tests * Fix linting * Remove unnecessary data-test-id
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR only includes tests for the FormLabel component but no storybook. The FormLabel is a React Bootstrap component that we aim to deprecate asap, so the goal of this PR is only to contribute to the stability of the system as it currently stands with no additional investment.
This PR also moves the FormLabel component to a dedicated directory.