-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: ErrorBoundary dedicated directory and tests #13276
Conversation
Thank you @geido for adding test to this component, which previously have no test coverage at all. 🙏 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just minor nit. Let me know if you want to address or if I should merge as is.
Codecov Report
@@ Coverage Diff @@
## master #13276 +/- ##
==========================================
+ Coverage 72.29% 72.98% +0.68%
==========================================
Files 864 598 -266
Lines 44883 21266 -23617
Branches 5403 5498 +95
==========================================
- Hits 32450 15521 -16929
+ Misses 12224 5618 -6606
+ Partials 209 127 -82
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Add tests for ErrorBoundary * Remove original ErrorBoundary file * Prefer absolute path
SUMMARY
This PR adds the tests for the ErrorBoundary component while moving it to its own dedicated directory.