Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ErrorBoundary dedicated directory and tests #13276

Merged
merged 3 commits into from
Mar 1, 2021
Merged

test: ErrorBoundary dedicated directory and tests #13276

merged 3 commits into from
Mar 1, 2021

Conversation

geido
Copy link
Member

@geido geido commented Feb 22, 2021

SUMMARY

This PR adds the tests for the ErrorBoundary component while moving it to its own dedicated directory.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Feb 22, 2021
@geido geido changed the title test: Add tests for ErrorBoundary component and dedicated directory test: ErrorBoundary dedicated directory and tests Feb 22, 2021
@geido geido closed this Feb 22, 2021
@geido geido reopened this Feb 22, 2021
@junlincc junlincc requested review from ktmud, nytai and rusackas February 23, 2021 04:01
@junlincc
Copy link
Member

Thank you @geido for adding test to this component, which previously have no test coverage at all. 🙏 🙂

Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just minor nit. Let me know if you want to address or if I should merge as is.

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #13276 (5efc2f1) into master (9b5e66b) will increase coverage by 0.68%.
The diff coverage is 62.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13276      +/-   ##
==========================================
+ Coverage   72.29%   72.98%   +0.68%     
==========================================
  Files         864      598     -266     
  Lines       44883    21266   -23617     
  Branches     5403     5498      +95     
==========================================
- Hits        32450    15521   -16929     
+ Misses      12224     5618    -6606     
+ Partials      209      127      -82     
Flag Coverage Δ
cypress 57.65% <33.94%> (?)
javascript 62.79% <59.02%> (+0.54%) ⬆️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/Chart.jsx 64.15% <0.00%> (+20.29%) ⬆️
...rc/common/components/Collapse/Collapse.stories.tsx 0.00% <0.00%> (ø)
...-frontend/src/common/components/Collapse/index.tsx 100.00% <ø> (ø)
...set-frontend/src/common/components/Modal/Modal.tsx 100.00% <ø> (ø)
...-frontend/src/common/components/common.stories.tsx 0.00% <ø> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
...mponents/AsyncAceEditor/AsyncAceEditor.stories.tsx 0.00% <0.00%> (ø)
...t-frontend/src/components/AsyncAceEditor/index.tsx 87.75% <ø> (ø)
...rset-frontend/src/components/AsyncSelect/index.jsx 96.29% <ø> (ø)
...rset-frontend/src/components/DeleteModal/index.tsx 100.00% <ø> (ø)
... and 627 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b5e66b...2c06e03. Read the comment docs.

@rusackas rusackas merged commit 5811e3f into apache:master Mar 1, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* Add tests for ErrorBoundary

* Remove original ErrorBoundary file

* Prefer absolute path
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants