Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adds storybook to Timer component #13343

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Adds storybook to Timer component
  • Moves Timer component to own folder
  • Moves Timer tests to component's folder

TEST PLAN

1 - Execute Timer tests
2 - All tests should pass

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #13343 (cf12951) into master (d39bc14) will increase coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13343      +/-   ##
==========================================
+ Coverage   72.26%   72.69%   +0.42%     
==========================================
  Files         876      577     -299     
  Lines       45409    21027   -24382     
  Branches     5440     5441       +1     
==========================================
- Hits        32815    15285   -17530     
+ Misses      12384     5619    -6765     
+ Partials      210      123      -87     
Flag Coverage Δ
cypress 58.16% <ø> (?)
hive ?
javascript 62.28% <0.00%> (+0.01%) ⬆️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/ResultSet.tsx 68.98% <ø> (-0.33%) ⬇️
...rset-frontend/src/components/DeleteModal/index.tsx 100.00% <ø> (ø)
...et-frontend/src/components/Timer/Timer.stories.tsx 0.00% <0.00%> (ø)
superset-frontend/src/components/Timer/index.tsx 95.83% <ø> (ø)
...ontend/src/components/URLShortLinkButton/index.jsx 100.00% <ø> (ø)
...et-frontend/src/messageToasts/components/Toast.tsx 92.68% <ø> (+4.87%) ⬆️
superset-frontend/src/views/routes.tsx 56.81% <0.00%> (-6.82%) ⬇️
...rontend/src/explore/components/DatasourcePanel.tsx 76.00% <0.00%> (-3.17%) ⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx 84.33% <0.00%> (-1.03%) ⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 62.50% <0.00%> (-0.66%) ⬇️
... and 512 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39bc14...6be29b1. Read the comment docs.

@rusackas rusackas merged commit fd5ce35 into apache:master Mar 1, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants