Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adds storybook to EditableTitle component #13362

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Adds storybook to EditableTitle component
  • Moves EditableTitle tests to component's folder

TEST PLAN

1 - Execute EditableTitle tests
2 - All tests should pass

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #13362 (b3eb238) into master (b4ca39c) will decrease coverage by 4.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13362      +/-   ##
==========================================
- Coverage   77.12%   72.82%   -4.30%     
==========================================
  Files         894      595     -299     
  Lines       45672    21254   -24418     
  Branches     5492     5493       +1     
==========================================
- Hits        35223    15478   -19745     
+ Misses      10325     5652    -4673     
  Partials      124      124              
Flag Coverage Δ
cypress 58.09% <ø> (+<0.01%) ⬆️
hive ?
javascript 62.37% <0.00%> (-0.03%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/EditableTitle/EditableTitle.stories.tsx 0.00% <0.00%> (ø)
...et-frontend/src/components/EditableTitle/index.tsx 75.30% <ø> (ø)
superset/commands/base.py
superset/examples/flights.py
superset/examples/birth_names.py
superset/db_engine_specs/clickhouse.py
superset/queries/schemas.py
superset/models/schedules.py
superset/utils/cache.py
superset/examples/random_time_series.py
... and 293 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ca39c...10e6dc1. Read the comment docs.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 45aa812 into apache:master Mar 3, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants