-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: convert chartReducer to TypeScript #13374
Conversation
@@ -134,7 +143,7 @@ export default function chartReducer(charts = {}, action) { | |||
} | |||
const annotationQuery = { | |||
...state.annotationQuery, | |||
[action.annotation.name]: action.queryRequest, | |||
[action.annotation.name]: action.queryController, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bycatch by TypeScript: it seems the ANNOTATION_QUERY_STARTED
is supposed to cancel previous annotation queries, but it used the wrong action prop. The source of the action is here:
return { type: ANNOTATION_QUERY_STARTED, annotation, queryController, key }; |
Codecov Report
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
+ Coverage 72.13% 77.02% +4.89%
==========================================
Files 898 898
Lines 45681 45725 +44
Branches 5495 5423 -72
==========================================
+ Hits 32952 35221 +2269
+ Misses 12517 10375 -2142
+ Partials 212 129 -83
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SUMMARY
Follow up of #13221 , converting
chartReducer
to TypeScript.Other related components waiting to be converted:
chartAction
ChartRenderer
exploreReducer
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI should pass, all Explore page functionalities should work as before
ADDITIONAL INFORMATION