Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add set data mask to build query #13417

Merged
merged 3 commits into from
Mar 4, 2021

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Mar 2, 2021

SUMMARY

Add setDataMask to buildQuery of charts, this will give to us opportunity to manage external chart data like ownData before it comes to component itself on build query stage

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc requested a review from villebro March 2, 2021 17:27
@junlincc
Copy link
Member

junlincc commented Mar 2, 2021

@simcha90 could you please add more description to the PR? thanks!

@villebro
Copy link
Member

villebro commented Mar 2, 2021

Related PR: apache-superset/superset-ui#985

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #13417 (0287910) into master (b04aebf) will decrease coverage by 4.18%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13417      +/-   ##
==========================================
- Coverage   77.23%   73.04%   -4.19%     
==========================================
  Files         900      599     -301     
  Lines       45601    21150   -24451     
  Branches     5415     5492      +77     
==========================================
- Hits        35221    15450   -19771     
+ Misses      10253     5573    -4680     
  Partials      127      127              
Flag Coverage Δ
cypress 57.94% <75.00%> (+<0.01%) ⬆️
hive ?
javascript 62.75% <50.00%> (-0.01%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/chartAction.js 78.00% <66.66%> (-0.18%) ⬇️
superset-frontend/src/explore/exploreUtils.js 70.55% <100.00%> (ø)
superset/examples/helpers.py
superset/commands/utils.py
superset/utils/machine_auth.py
superset/db_engine_specs/gsheets.py
superset/utils/public_interfaces.py
superset/db_engine_specs/__init__.py
superset/forms.py
superset/databases/dao.py
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04aebf...eedda47. Read the comment docs.

@simcha90
Copy link
Contributor Author

simcha90 commented Mar 2, 2021

@simcha90 could you please add more description to the PR? thanks!

added @junlincc

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 7f0fbb5 into apache:master Mar 4, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* refactor: add set data mask to build query

* refactor: update hooks placement
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants