-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add set data mask to build query #13417
Conversation
@simcha90 could you please add more description to the PR? thanks! |
Related PR: apache-superset/superset-ui#985 |
Codecov Report
@@ Coverage Diff @@
## master #13417 +/- ##
==========================================
- Coverage 77.23% 73.04% -4.19%
==========================================
Files 900 599 -301
Lines 45601 21150 -24451
Branches 5415 5492 +77
==========================================
- Hits 35221 15450 -19771
+ Misses 10253 5573 -4680
Partials 127 127
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactor: add set data mask to build query * refactor: update hooks placement
SUMMARY
Add
setDataMask
tobuildQuery
of charts, this will give to us opportunity to manage external chart data likeownData
before it comes to component itself on build query stageBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION