-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(native-filters): Move filtersState
to dataMask
redux root
#13437
Conversation
filtersState
to dataMask
redux root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass comments
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadePopover.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass - mostly import nits but also a question about whether dataMask
should be under src
or src/dashboard
.
superset-frontend/spec/javascripts/dashboard/fixtures/mockNativeFilters.js
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadePopover.tsx
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,62 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the reasoning behind having dataMask
on the root level, as they will be used in viz, filters, dashboard and explore, but I still feel superset-frontend/src/dashboard/dataMask
might be more appropriate, as that's where these masks are primarily used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the same reason why we put chart
in the root, it's parallel to chart I think... Also this feature have enough functionality to have independent place in root :) Also I think in future we will need to add here also ui filtering
like ui changes that will applied to other charts, may be also we will need to use here to show how it's applied to itself
superset-frontend/src/explore/components/ExploreViewContainer.jsx
Outdated
Show resolved
Hide resolved
FYI @simcha90 this needs a rebase (also left a few comments) |
…_to_data_mask � Conflicts: � superset-frontend/package-lock.json � superset-frontend/package.json
Codecov Report
@@ Coverage Diff @@
## master #13437 +/- ##
==========================================
- Coverage 77.41% 73.37% -4.04%
==========================================
Files 909 611 -298
Lines 45863 21336 -24527
Branches 5534 5537 +3
==========================================
- Hits 35503 15656 -19847
+ Misses 10232 5550 -4682
- Partials 128 130 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -112,6 +112,7 @@ | |||
"geolib": "^2.0.24", | |||
"global-box": "^1.2.0", | |||
"html-webpack-plugin": "^4.5.1", | |||
"immer": "^8.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding a new library, it would be nice to add a note in PR description to explain why it is needed. Sometimes it's not very obvious what the purpose of the library is.
SUMMARY
This PR move
(dashboard redux state) -> nativeFilters -> filtersState
toredux -> dataMask
because of next reasons:dataMask
naming instead offiltersState
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-03-04.at.11.21.14.mov
TEST PLAN
ADDITIONAL INFORMATION