Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove view in sql lab from druid datasources #13469

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Mar 4, 2021

SUMMARY

This bug was reported internally, when you try to view in sql lab from a druid datasource with the native druid connector, it causes a JS error in sql lab. However, I don't think you should be able to open a native druid datasource in sql lab at all, so i'm removing this functionality

TEST PLAN

CI and new unit test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @graceguo-supercat @ktmud @hughhhh

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #13469 (a37bd2d) into master (c3c7376) will decrease coverage by 3.89%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13469      +/-   ##
==========================================
- Coverage   77.38%   73.48%   -3.90%     
==========================================
  Files         906      605     -301     
  Lines       45712    21266   -24446     
  Branches     5440     5524      +84     
==========================================
- Hits        35372    15627   -19745     
+ Misses      10213     5512    -4701     
  Partials      127      127              
Flag Coverage Δ
cypress 57.95% <75.00%> (+0.03%) ⬆️
hive ?
javascript 63.40% <75.00%> (+<0.01%) ⬆️
mysql ?
postgres ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../explore/components/controls/DatasourceControl.jsx 64.28% <75.00%> (+1.59%) ⬆️
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (-1.52%) ⬇️
superset/typing.py
superset/views/tags.py
superset/db_engine_specs/snowflake.py
superset/db_engine_specs/bigquery.py
superset/utils/cache_manager.py
superset/sql_parse.py
superset/common/query_context.py
superset/tasks/scheduler.py
... and 294 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c7376...441b892. Read the comment docs.

@etr2460 etr2460 merged commit d2e03ab into apache:master Mar 4, 2021
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Mar 5, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants