Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes Select duplication #13477

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Mar 5, 2021

SUMMARY

This PR removes Select duplication by moving old src/common/components/Select to src/components/Select folder. To achieve that, the old component was renamed to NativeSelect. Currently, our Select component uses react-select but we should migrate it to AntD so this PR is an intermediary step in our refactoring process with the objective of organizing all Select in the same folder.

TEST PLAN

1 - Execute all tests.
2 - All tests should pass.

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #13477 (c4684fe) into master (fa072cd) will decrease coverage by 4.27%.
The diff coverage is 100.00%.

❗ Current head c4684fe differs from pull request most recent head 95b82a6. Consider uploading reports for the commit 95b82a6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13477      +/-   ##
==========================================
- Coverage   77.38%   73.11%   -4.28%     
==========================================
  Files         928      615     -313     
  Lines       47016    21864   -25152     
  Branches     5719     5719              
==========================================
- Hits        36384    15985   -20399     
+ Misses      10489     5736    -4753     
  Partials      143      143              
Flag Coverage Δ
cypress 56.43% <100.00%> (+<0.01%) ⬆️
hive ?
javascript 63.15% <87.50%> (-0.01%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Control/AdhocFilterEditPopoverSimpleTabContent.jsx 74.83% <ø> (ø)
...terControl/AdhocFilterEditPopoverSqlTabContent.jsx 63.33% <ø> (ø)
.../controls/MetricControl/AdhocMetricEditPopover.jsx 79.54% <ø> (ø)
...et-frontend/src/components/Select/NativeSelect.tsx 100.00% <100.00%> (ø)
superset-frontend/src/components/Select/index.ts 100.00% <100.00%> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 62.44% <100.00%> (-0.09%) ⬇️
superset/models/slice.py
superset/examples/big_data.py
superset/databases/commands/create.py
superset/utils/dict_import_export.py
... and 309 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa072cd...95b82a6. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina force-pushed the tests-audit-select-duplicate branch from bf32f99 to 95b82a6 Compare March 19, 2021 18:04
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 19, 2021
@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://34.217.70.102:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested all the places this touches.

@rusackas rusackas merged commit 8ddcba8 into apache:master Mar 31, 2021
@rusackas
Copy link
Member

@robdiciuccio not sure if the testenv was super delayed due to GH Actions queueing, or if there's something else afoot with this one.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

Ephemeral environment shutdown and build artifacts deleted.

lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants