-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removes Select duplication #13477
chore: Removes Select duplication #13477
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13477 +/- ##
==========================================
- Coverage 77.38% 73.11% -4.28%
==========================================
Files 928 615 -313
Lines 47016 21864 -25152
Branches 5719 5719
==========================================
- Hits 36384 15985 -20399
+ Misses 10489 5736 -4753
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bf32f99
to
95b82a6
Compare
/testenv up |
@junlincc Ephemeral environment spinning up at http://34.217.70.102:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested all the places this touches.
@robdiciuccio not sure if the testenv was super delayed due to GH Actions queueing, or if there's something else afoot with this one. |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR removes
Select
duplication by moving oldsrc/common/components/Select
tosrc/components/Select
folder. To achieve that, the old component was renamed toNativeSelect
. Currently, ourSelect
component usesreact-select
but we should migrate it to AntD so this PR is an intermediary step in our refactoring process with the objective of organizing allSelect
in the same folder.TEST PLAN
1 - Execute all tests.
2 - All tests should pass.
@rusackas @junlincc
ADDITIONAL INFORMATION