Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): fix initial filter loading #13546

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

simcha90
Copy link
Contributor

SUMMARY

This PR fix bug that default values on first loading applied to all charts out of scope

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro changed the title fix: fix initial filter loading fix(native-filters): fix initial filter loading Mar 10, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing! 👍

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #13546 (d0bb8b7) into master (1d1a1cd) will decrease coverage by 3.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13546      +/-   ##
==========================================
- Coverage   77.31%   73.68%   -3.64%     
==========================================
  Files         903      602     -301     
  Lines       45926    21345   -24581     
  Branches     5624     5624              
==========================================
- Hits        35508    15727   -19781     
+ Misses      10282     5484    -4798     
+ Partials      136      134       -2     
Flag Coverage Δ
cypress 57.31% <ø> (+0.85%) ⬆️
javascript 63.48% <ø> (ø)
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/dashboard/containers/Chart.jsx 100.00% <ø> (ø)
superset/db_engine_specs/cockroachdb.py
superset/views/database/forms.py
superset/views/base.py
superset/queries/saved_queries/commands/export.py
superset/jinja_context.py
superset/sql_validators/postgres.py
superset/views/annotations.py
superset/db_engine_specs/elasticsearch.py
superset/examples/random_time_series.py
... and 302 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1a1cd...9003edb. Read the comment docs.

@villebro villebro merged commit 70ccc26 into apache:master Mar 10, 2021
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Mar 12, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants