Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: useChangeEffect #13555

Merged
merged 1 commit into from
Mar 18, 2021
Merged

test: useChangeEffect #13555

merged 1 commit into from
Mar 18, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 10, 2021

Tests for hook useChangeEffect

@yardz yardz changed the title Tests: useChangeEffect tests: useChangeEffect Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #13555 (7c9ca63) into master (70ccc26) will decrease coverage by 3.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13555      +/-   ##
==========================================
- Coverage   77.40%   73.56%   -3.84%     
==========================================
  Files         904      604     -300     
  Lines       45987    21402   -24585     
  Branches     5554     5640      +86     
==========================================
- Hits        35594    15744   -19850     
+ Misses      10258     5524    -4734     
+ Partials      135      134       -1     
Flag Coverage Δ
cypress 57.20% <100.00%> (+0.60%) ⬆️
hive ?
javascript 63.38% <100.00%> (-0.01%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/TemplateParamsEditor.jsx 23.80% <ø> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Badge/index.tsx 100.00% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 66.38% <ø> (ø)
...frontend/src/common/hooks/useChangeEffect/index.ts 100.00% <100.00%> (ø)
...rc/common/hooks/useChangeEffect/useChangeEffect.ts 100.00% <100.00%> (ø)
superset-frontend/src/explore/exploreUtils.js 69.81% <100.00%> (-0.75%) ⬇️
...erset-frontend/src/profile/components/Security.tsx 100.00% <100.00%> (ø)
superset/jinja_context.py
superset/dashboards/commands/importers/v0.py
... and 307 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ccc26...9ce7609. Read the comment docs.

@yardz yardz closed this Mar 11, 2021
@yardz yardz reopened this Mar 11, 2021
@yardz yardz closed this Mar 11, 2021
@yardz yardz reopened this Mar 11, 2021
@yardz yardz changed the title tests: useChangeEffect test: useChangeEffect Mar 11, 2021
@yardz
Copy link
Contributor Author

yardz commented Mar 12, 2021

@nytai or @ktmud Can either of you see this PR for me? Thanks!

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud ktmud merged commit e6c5bf4 into apache:master Mar 18, 2021
@willbarrett
Copy link
Member

LGTM

allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants