Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cross-filters): Add scoping for cross filters #13625

Merged
merged 8 commits into from
Mar 17, 2021

Conversation

simcha90
Copy link
Contributor

SUMMARY

This PR add scoping for cross filters

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-03-15.at.16.30.10.mov

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc
Copy link
Member

/testenv up

@villebro
Copy link
Member

This is pretty amazing stuff @simcha90 ! 🎉

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://34.221.28.173:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

@robdiciuccio how can i turn on FFs in testenv? most of the features that needed to be tested are actually under FF or in Superset-UI currently. Is there a way to optimize it? 🙏

@simcha90
Copy link
Contributor Author

simcha90 commented Mar 17, 2021

@robdiciuccio how can i turn on FFs in testenv? most of the features that needed to be tested are actually under FF or in Superset-UI currently. Is there a way to optimize it? 🙏

This way I enable it in local env
image

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #13625 (23a0e9b) into master (a35825d) will decrease coverage by 4.43%.
The diff coverage is 81.80%.

❗ Current head 23a0e9b differs from pull request most recent head 7ef62e7. Consider uploading reports for the commit 7ef62e7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13625      +/-   ##
==========================================
- Coverage   77.21%   72.77%   -4.44%     
==========================================
  Files         912      921       +9     
  Lines       46449    46735     +286     
  Branches     5725     5733       +8     
==========================================
- Hits        35866    34012    -1854     
- Misses      10447    12508    +2061     
- Partials      136      215      +79     
Flag Coverage Δ
cypress ?
hive 80.25% <95.54%> (+0.19%) ⬆️
javascript 63.15% <54.59%> (+0.10%) ⬆️
mysql 80.55% <95.84%> (?)
postgres 80.60% <95.84%> (+0.19%) ⬆️
presto 80.28% <94.95%> (+0.19%) ⬆️
python 81.10% <95.84%> (+0.22%) ⬆️
sqlite 80.22% <95.54%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 58.72% <ø> (-4.32%) ⬇️
superset-frontend/src/chart/chartAction.js 50.00% <0.00%> (-28.00%) ⬇️
...nd/src/components/SupersetResourceSelect/index.tsx 70.00% <ø> (ø)
...et-frontend/src/dashboard/actions/nativeFilters.ts 30.76% <ø> (-33.34%) ⬇️
...perset-frontend/src/dashboard/containers/Chart.jsx 100.00% <ø> (ø)
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <ø> (-100.00%) ⬇️
...frontend/src/dashboard/reducers/getInitialState.js 0.00% <0.00%> (-84.27%) ⬇️
superset-frontend/src/dashboard/reducers/types.ts 0.00% <0.00%> (ø)
...tend/src/explore/components/DisplayQueryButton.jsx 43.75% <0.00%> (-32.06%) ⬇️
...-frontend/src/explore/components/controls/index.js 100.00% <ø> (ø)
... and 292 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a35825d...7ef62e7. Read the comment docs.

@villebro villebro merged commit 0e0c99b into apache:master Mar 17, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Mar 17, 2021
@robdiciuccio
Copy link
Member

@junlincc feature flag and config overrides can be added if there's demand for those features. not currently possible, though.

@junlincc junlincc added dashboard:cross-filters Related to the Dashboard cross filters test:case release:note and removed dashboard:native-filters Related to the native filters of the Dashboard labels Apr 27, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* feat: cross filter modal

* refactor: add charts metadata

* refactor: add charts metadata

* feat: cross filters scoping

* fix: fix CR notes

* test: fix test

* lint: fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:cross-filters Related to the Dashboard cross filters release:note size/XL test:case 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants