Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: implement codecov carryforward flags #13677

Merged

Conversation

jfrag1
Copy link
Member

@jfrag1 jfrag1 commented Mar 17, 2021

SUMMARY

Attempts to implement carry-forward flags for codecov as proposed here

The goal is that for any new commits, codecov will pull coverage data for unchanged areas of the codebase from previous commits, only recalculating coverage for areas of the codebase that have changed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Testing will involve waiting for CI to see if the carry-forward flags are working as intended and continuing to tweak until it's working

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added the need:more-info Requires more information from author label Mar 18, 2021
@junlincc
Copy link
Member

@jfrag1 thanks for your contribution! can you provide some details in the PR description? thanks!

@jfrag1 jfrag1 changed the title Test small config change for carryforward flags build: implement codecov carryforward flags Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #13677 (3a17c51) into master (375ded9) will increase coverage by 1.28%.
The diff coverage is 100.00%.

❗ Current head 3a17c51 differs from pull request most recent head d298a3f. Consider uploading reports for the commit d298a3f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13677      +/-   ##
==========================================
+ Coverage   76.03%   77.31%   +1.28%     
==========================================
  Files         928      928              
  Lines       47002    47005       +3     
  Branches     5724     5724              
==========================================
+ Hits        35738    36342     +604     
+ Misses      11098    10520     -578     
+ Partials      166      143      -23     
Flag Coverage Δ
cypress 56.48% <ø> (+4.25%) ⬆️
hive 80.25% <100.00%> (+<0.01%) ⬆️
mysql 80.56% <100.00%> (+<0.01%) ⬆️
postgres 80.59% <100.00%> (+<0.01%) ⬆️
presto ?
python 80.97% <100.00%> (-0.13%) ⬇️
sqlite 80.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/app.py 81.25% <100.00%> (+0.06%) ⬆️
superset/db_engine_specs/presto.py 82.84% <0.00%> (-5.44%) ⬇️
superset/connectors/sqla/models.py 89.87% <0.00%> (-0.61%) ⬇️
...erset-frontend/src/SqlLab/components/ResultSet.tsx 68.64% <0.00%> (-0.30%) ⬇️
superset/models/core.py 89.10% <0.00%> (-0.28%) ⬇️
superset-frontend/src/explore/exploreUtils.js 69.81% <0.00%> (+0.62%) ⬆️
superset-frontend/src/components/ListView/utils.ts 85.95% <0.00%> (+0.82%) ⬆️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 61.25% <0.00%> (+1.25%) ⬆️
superset-frontend/src/components/Select/styles.tsx 86.30% <0.00%> (+1.36%) ⬆️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 56.01% <0.00%> (+1.38%) ⬆️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375ded9...d298a3f. Read the comment docs.

@junlincc junlincc added preset-io and removed need:more-info Requires more information from author labels Mar 18, 2021
@junlincc junlincc requested a review from ktmud March 18, 2021 21:11
@jfrag1
Copy link
Member Author

jfrag1 commented Mar 18, 2021

The fact that the codecov bot's report only showed six flags rather than the usual seven leads me to believe that this change is at least somewhat functional.

Screen Shot 2021-03-18 at 4 38 55 PM

I'm guessing that this branch being about a day behind master is the reason for these coverage changes reported by the codecov bot on this PR.

Screen Shot 2021-03-18 at 4 10 58 PM

I plan on rebasing and re-running CI tonight when fewer actions are queued up to try to isolate the temporary print statement. If it works as intended, we should see codecov only reporting the python flag.

@ktmud
Copy link
Member

ktmud commented Mar 19, 2021

This indeed seems to be working! Can't believe it is as simple as adding one config value. Thought we'd have to add file name matching for flags or something...

@jfrag1 jfrag1 force-pushed the implement-codecov-carryforward-flags branch from 9e4f241 to 811863c Compare March 19, 2021 01:54
@Psyruss77
Copy link

Ss

@willbarrett willbarrett merged commit 2deb9c2 into apache:master Mar 22, 2021
@willbarrett willbarrett deleted the implement-codecov-carryforward-flags branch March 22, 2021 21:21
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* Test small config change for carryforward flags

* redo print statement

* newline

* Remove print statement
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants