-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: implement codecov carryforward flags #13677
build: implement codecov carryforward flags #13677
Conversation
@jfrag1 thanks for your contribution! can you provide some details in the PR description? thanks! |
Codecov Report
@@ Coverage Diff @@
## master #13677 +/- ##
==========================================
+ Coverage 76.03% 77.31% +1.28%
==========================================
Files 928 928
Lines 47002 47005 +3
Branches 5724 5724
==========================================
+ Hits 35738 36342 +604
+ Misses 11098 10520 -578
+ Partials 166 143 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The fact that the codecov bot's report only showed six flags rather than the usual seven leads me to believe that this change is at least somewhat functional. I'm guessing that this branch being about a day behind master is the reason for these coverage changes reported by the codecov bot on this PR. I plan on rebasing and re-running CI tonight when fewer actions are queued up to try to isolate the temporary print statement. If it works as intended, we should see codecov only reporting the python flag. |
This indeed seems to be working! Can't believe it is as simple as adding one config value. Thought we'd have to add file name matching for flags or something... |
9e4f241
to
811863c
Compare
Ss |
* Test small config change for carryforward flags * redo print statement * newline * Remove print statement
SUMMARY
Attempts to implement carry-forward flags for codecov as proposed here
The goal is that for any new commits, codecov will pull coverage data for unchanged areas of the codebase from previous commits, only recalculating coverage for areas of the codebase that have changed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Testing will involve waiting for CI to see if the carry-forward flags are working as intended and continuing to tweak until it's working
ADDITIONAL INFORMATION