Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cross-filters): expand relevant indicator sections #13703

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

villebro
Copy link
Member

SUMMARY

Currently the cross filter panel doesn't always expand when clicking the filter indicator. This applies the defaults every time the indicator is clicked.

AFTER

image

BEFORE

image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #13703 (71f7baa) into master (375ded9) will decrease coverage by 2.93%.
The diff coverage is 0.00%.

❗ Current head 71f7baa differs from pull request most recent head 3c1d831. Consider uploading reports for the commit 3c1d831 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13703      +/-   ##
==========================================
- Coverage   76.03%   73.09%   -2.94%     
==========================================
  Files         928      615     -313     
  Lines       47002    21852   -25150     
  Branches     5724     5806      +82     
==========================================
- Hits        35738    15973   -19765     
+ Misses      11098     5736    -5362     
+ Partials      166      143      -23     
Flag Coverage Δ
cypress 56.48% <0.00%> (+4.24%) ⬆️
hive ?
javascript 63.13% <0.00%> (+<0.01%) ⬆️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dashboard/components/FiltersBadge/DetailsPanel.tsx 67.30% <0.00%> (+11.75%) ⬆️
...erset-frontend/src/SqlLab/components/ResultSet.tsx 68.64% <0.00%> (-0.30%) ⬇️
superset/db_engine_specs/redshift.py
superset/models/sql_types/base.py
superset/views/chart/views.py
superset/db_engine_specs/bigquery.py
superset/examples/helpers.py
superset/migrations/shared/utils.py
superset/security/__init__.py
superset/views/tags.py
... and 394 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375ded9...3c1d831. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review March 19, 2021 09:51
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 87d1afc into apache:master Mar 19, 2021
@villebro villebro deleted the villebro/cross-filter-active branch March 19, 2021 09:52
@junlincc junlincc added the dashboard:indicator Related to the filter indicator of a Dashboard label Mar 25, 2021
@junlincc junlincc added dashboard:cross-filters Related to the Dashboard cross filters and removed dashboard:indicator Related to the filter indicator of a Dashboard labels Apr 27, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:cross-filters Related to the Dashboard cross filters preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants