fix: Disallows negative options remaining in SelectControl #13749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13749 +/- ##
==========================================
+ Coverage 77.23% 77.47% +0.23%
==========================================
Files 933 933
Lines 47383 47186 -197
Branches 5928 5860 -68
==========================================
- Hits 36597 36555 -42
+ Misses 10638 10489 -149
+ Partials 148 142 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
approved these changes
Mar 23, 2021
junlincc
added
need:merge
|
LGTM! Thanks for the enhancement @ktmud can you help merge, thanks! |
junlin-qa
approved these changes
Mar 27, 2021
amitmiran137
pushed a commit
that referenced
this pull request
Mar 31, 2021
* master: (56 commits) test: Adds tests and storybook to CertifiedIcon component (#13457) chore: Moves CheckboxIcons to Checkbox folder (#13459) chore: Removes Popover duplication (#13462) build(deps): bump elliptic from 6.5.3 to 6.5.4 in /docs (#13527) fix: allow spaces in DB names (#13800) chore: Update PR template for SIP-59 DB migrations process (#13855) Add CODEOWNERS (#13759) feat(alerts & reports): Easier to read execution logs (#13752) fix: Disallows negative options remaining (#13749) Fix broken link (#13861) fix(native-filters): add global async query support to native filters (#13837) Displays row limit warning with Alert component (#13854) fix(errors): Downgrade error on stop query to a warning (#13826) fix(alerts and reports): Unify timestamp format on execution log view (#13718) fix(sqllab): warning message when rows limited (#13841) chore: add success log whenever a connection is working (#13811) fix(native-filters): improve loading styles for filter component (#13794) chore: update change log with cherry-picks for release 1.1 (#13824) feat: added support to configure the default explorer viz (#13610) fix(#13734): Properly escape special characters in CSV output (#13735) ...
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Disallows negative options remaining in
SelectControl. When aSelectControlhas no options available, the user can still enter values and this caused the assistive text to contain negative values.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
1 - Find a
SelectControlwith no options available (polygon chart -> customize for example).2 - Enter arbitrary text as a value.
3 - No assistive text should be displayed.
@rusackas @junlincc
ADDITIONAL INFORMATION