Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: changing logger.exception to logger.errors in databases api #13751

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

AAfghahi
Copy link
Member

SUMMARY

Changing the logger.exception in databases to logger.error in order to better read the logs and see what information the client is passing in on a failed import.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

@AAfghahi AAfghahi changed the title test: changie from exceptions to errors test: changing logger.exception to logger.errors in databases api Mar 23, 2021
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #13751 (08392c8) into master (9773aba) will increase coverage by 1.56%.
The diff coverage is 0.00%.

❗ Current head 08392c8 differs from pull request most recent head 36b9f63. Consider uploading reports for the commit 36b9f63 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13751      +/-   ##
==========================================
+ Coverage   75.91%   77.47%   +1.56%     
==========================================
  Files         933      933              
  Lines       47185    47186       +1     
  Branches     5872     5872              
==========================================
+ Hits        35821    36558     +737     
+ Misses      11191    10486     -705     
+ Partials      173      142      -31     
Flag Coverage Δ
cypress 56.26% <ø> (+10.24%) ⬆️
hive 80.25% <0.00%> (ø)
mysql 80.56% <0.00%> (ø)
postgres 80.59% <0.00%> (ø)
presto 80.25% <0.00%> (-0.01%) ⬇️
python 81.10% <0.00%> (-0.01%) ⬇️
sqlite 80.15% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/api.py 92.03% <0.00%> (ø)
superset/datasets/api.py 91.44% <0.00%> (ø)
superset/db_engine_specs/presto.py 88.28% <0.00%> (-0.42%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 84.49% <0.00%> (+0.77%) ⬆️
superset-frontend/src/components/ListView/utils.ts 85.95% <0.00%> (+0.82%) ⬆️
.../src/explore/components/ControlPanelsContainer.tsx 97.27% <0.00%> (+0.90%) ⬆️
superset-frontend/src/components/Select/styles.tsx 86.30% <0.00%> (+1.36%) ⬆️
superset-frontend/src/chart/Chart.jsx 64.81% <0.00%> (+1.85%) ⬆️
...-frontend/src/dashboard/actions/dashboardLayout.js 98.03% <0.00%> (+1.96%) ⬆️
...frontend/src/dashboard/reducers/dashboardLayout.js 99.00% <0.00%> (+2.00%) ⬆️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9773aba...36b9f63. Read the comment docs.

@hughhhh hughhhh merged commit 6137a20 into apache:master Mar 24, 2021
@hughhhh hughhhh deleted the eventLogger branch March 24, 2021 17:13
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants