Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad copy-and-paste in API spec #13790

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Found a bad copy-and-paste while going over the codebase, affecting the API spec.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida added need:merge The PR is ready to be merged and removed size/XS labels Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #13790 (dd98a0f) into master (7efe5a8) will decrease coverage by 0.04%.
The diff coverage is 28.12%.

❗ Current head dd98a0f differs from pull request most recent head ef3d65f. Consider uploading reports for the commit ef3d65f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13790      +/-   ##
==========================================
- Coverage   77.39%   77.35%   -0.05%     
==========================================
  Files         933      933              
  Lines       47188    47192       +4     
  Branches     5861     5867       +6     
==========================================
- Hits        36523    36507      -16     
- Misses      10523    10543      +20     
  Partials      142      142              
Flag Coverage Δ
cypress 56.30% <14.81%> (+0.06%) ⬆️
hive ?
mysql 80.56% <ø> (ø)
postgres 80.59% <ø> (ø)
presto 80.26% <ø> (?)
python 80.84% <ø> (-0.14%) ⬇️
sqlite 80.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/components/FormLabel/index.tsx 100.00% <ø> (ø)
superset/datasets/api.py 91.44% <ø> (ø)
...tend/src/SqlLab/components/ScheduleQueryButton.tsx 28.12% <28.12%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 74.23% <0.00%> (-16.54%) ⬇️
superset/models/core.py 89.37% <0.00%> (+0.27%) ⬆️
superset/connectors/sqla/models.py 90.48% <0.00%> (+0.60%) ⬆️
...set-frontend/src/dashboard/util/getDropPosition.js 92.42% <0.00%> (+1.51%) ⬆️
...et-frontend/src/dashboard/components/Dashboard.jsx 89.47% <0.00%> (+4.21%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7efe5a8...ef3d65f. Read the comment docs.

@suddjian suddjian merged commit 7c23dfc into apache:master Mar 25, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants