Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ShareMenuItems #13860

Merged
merged 10 commits into from
Apr 9, 2021
Merged

test: ShareMenuItems #13860

merged 10 commits into from
Apr 9, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 29, 2021

SUMMARY

Tests for component ShareMenuItems

@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited
Loading

Codecov Report

Merging #13860 (ce4b51d) into master (84560e8) will increase coverage by 1.69%.
The diff coverage is 84.00%.

❗ Current head ce4b51d differs from pull request most recent head cbda5f9. Consider uploading reports for the commit cbda5f9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13860      +/-   ##
==========================================
+ Coverage   77.33%   79.03%   +1.69%     
==========================================
  Files         935      939       +4     
  Lines       47278    47626     +348     
  Branches     5883     5990     +107     
==========================================
+ Hits        36564    37639    +1075     
+ Misses      10570     9860     -710     
+ Partials      144      127      -17
Flag Coverage Δ
cypress 56.04% <66.86%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/SqlLab/components/ScheduleQueryButton.tsx 28.12% <ø> (ø)
...et-frontend/src/SqlLab/components/TableElement.jsx 88.60% <ø> (+0.23%) ⬆️
...end/src/common/components/DropdownButton/index.tsx 24.00% <0.00%> (ø)
...frontend/src/components/DatabaseSelector/index.tsx 92.70% <ø> (+1.04%) ⬆️
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/components/Icon/index.tsx 100.00% <ø> (ø)
...rset-frontend/src/components/ProgressBar/index.tsx 100.00% <ø> (ø)
...ontend/src/components/URLShortLinkButton/index.jsx 100.00% <ø> (ø)
.../components/CrossFilterScopingModal/utils/index.ts 100.00% <ø> (ø)
...src/dashboard/components/PublishedStatus/index.jsx 100.00% <ø> (ø)
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84560e8...cbda5f9. Read the comment docs.

@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://52.37.202.175:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

michael-s-molina
michael-s-molina reviewed Mar 31, 2021
View reviewed changes
yardz and others added 9 commits April 1, 2021 11:23
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/menu/ShareMenuItems…
87f6da8 
…/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/menu/ShareMenuItems…
5d71a52 
…/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/menu/ShareMenuItems…
4d7f4fb 
…/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/menu/ShareMenuItems…
0e11a9f 
…/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/menu/ShareMenuItems…
feba3b0 
…/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/menu/ShareMenuItems…
62e9630 
…/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/menu/ShareMenuItems…
65e0fb1 
…/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/menu/ShareMenuItems…
424c316 
…/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/menu/ShareMenuItems…
cbda5f9 
…/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz yardz closed this Apr 7, 2021
@yardz yardz reopened this Apr 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2021

Ephemeral environment shutdown and build artifacts deleted.

@rusackas
Copy link
Member

rusackas commented Apr 8, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

@rusackas Ephemeral environment spinning up at http://54.190.184.95:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

junlincc commented Apr 9, 2021

@yardz thank you Bruno, for the PR!

It will be great to attach the UI of each component to help testing, going forward. cc @michael-s-molina @geido

rusackas
rusackas approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@rusackas rusackas merged commit 36f101e into apache:master Apr 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021

Ephemeral environment shutdown and build artifacts deleted.

allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@yardz @michael-s-molina
test: ShareMenuItems (apache#13860)
02e4cd6 
* Tests for ShareMenuItems

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

Co-authored-by: Michael S. Molina <[email protected]>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@yardz @michael-s-molina
test: ShareMenuItems (apache#13860)
9c5b1ac 
* Tests for ShareMenuItems

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

Co-authored-by: Michael S. Molina <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina left review comments

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yardz @junlincc @rusackas @michael-s-molina @mistercrunch