Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: CrossFilterScopingModal/utils #13876

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 30, 2021

SUMMARY

Tests for "CrossFilterScopingModal/utils"

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #13876 (7e7fbe4) into master (9d0bb3a) will increase coverage by 0.75%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13876      +/-   ##
==========================================
+ Coverage   76.78%   77.53%   +0.75%     
==========================================
  Files         935      936       +1     
  Lines       47292    47299       +7     
  Branches     5895     5910      +15     
==========================================
+ Hits        36311    36674     +363     
+ Misses      10824    10481     -343     
+ Partials      157      144      -13     
Flag Coverage Δ
cypress 56.02% <62.50%> (+3.71%) ⬆️
javascript 63.71% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/CrossFilterScopingModal/utils/index.ts 100.00% <ø> (ø)
superset-frontend/src/views/CRUD/alert/types.ts 100.00% <ø> (ø)
superset/models/reports.py 100.00% <ø> (ø)
superset/tasks/scheduler.py 0.00% <0.00%> (ø)
...end/src/views/CRUD/data/database/DatabaseModal.tsx 75.97% <57.14%> (-1.00%) ⬇️
.../src/explore/components/controls/SelectControl.jsx 93.75% <100.00%> (+4.46%) ⬆️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 100.00% <100.00%> (ø)
superset/reports/commands/execute.py 93.44% <100.00%> (ø)
superset/reports/logs/api.py 95.45% <100.00%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2760e...7e7fbe4. Read the comment docs.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modal works and LGTG!

@pkdotson pkdotson merged commit e829aa5 into apache:master Apr 3, 2021
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants