Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dashboard): Datasource -> Dataset #13939

Merged
merged 3 commits into from
Apr 2, 2021
Merged

chore(dashboard): Datasource -> Dataset #13939

merged 3 commits into from
Apr 2, 2021

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Apr 2, 2021 •
edited
Loading

SUMMARY

Just transitioning from deprecated terminology

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 2, 2021 •
edited
Loading

Codecov Report

Merging #13939 (a82c262) into master (4187d9e) will increase coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head a82c262 differs from pull request most recent head 21235ed. Consider uploading reports for the commit 21235ed to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13939      +/-   ##
==========================================
+ Coverage   77.91%   78.10%   +0.18%     
==========================================
  Files         934      934              
  Lines       47350    47349       -1     
  Branches     5941     5943       +2     
==========================================
+ Hits        36894    36983      +89     
+ Misses      10308    10222      -86     
+ Partials      148      144       -4
Flag Coverage Δ
cypress 56.03% <100.00%> (+2.80%) ⬆️
hive ?
javascript 66.32% <100.00%> (+0.03%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/dashboard/components/PublishedStatus/index.jsx 100.00% <ø> (ø)
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 100.00% <100.00%> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 93.02% <100.00%> (-0.09%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 74.42% <0.00%> (-16.42%) ⬇️
superset/db_engine_specs/presto.py 81.83% <0.00%> (-6.89%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 89.10% <0.00%> (-1.68%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (-1.52%) ⬇️
superset/db_engine_specs/base.py 86.62% <0.00%> (-0.46%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4187d9e...21235ed. Read the comment docs.

nytai
nytai approved these changes Apr 2, 2021
View reviewed changes
...ashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx Outdated
?.datasourceCount;
const hasColumn =
hasDatasource &&
hasDataset &&
!FILTERS_WITH_ONLY_DATASOURCE.includes(formFilter?.filterType);

const hasFilledDatasource =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this one be updated too?

...ashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx Outdated
@@ -271,7 +269,7 @@ export const FiltersConfigForm: React.FC<FiltersConfigFormProps> = ({
forceUpdate();
}}
filterId={filterId}
hasDatasource={hasDatasource}
hasDatasource={hasDataset}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this one?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 2, 2021
@junlincc junlincc added the need:merge The PR is ready to be merged label Apr 2, 2021
@suddjian suddjian merged commit e640b7f into master Apr 2, 2021
@junlincc junlincc removed the need:merge The PR is ready to be merged label Apr 5, 2021
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
@suddjian @lyndsiWilliams
chore(dashboard): Datasource -> Dataset (apache#13939)
6ccfcf1 
* chore(dashboard): Datasource -> Dataset

* lint

* more renaming datasource -> dataset
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@suddjian
chore(dashboard): Datasource -> Dataset (apache#13939)
20d0fa9 
* chore(dashboard): Datasource -> Dataset

* lint

* more renaming datasource -> dataset
@rusackas rusackas deleted the filter-dataset-terminology branch January 30, 2023 19:20
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suddjian @nytai @mistercrunch @junlincc