Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for the Dashboard FilterBar CascadeFilterControl component #13950

Merged
merged 2 commits into from
Apr 6, 2021
Merged

test: Add tests for the Dashboard FilterBar CascadeFilterControl component #13950

merged 2 commits into from
Apr 6, 2021

Conversation

geido
Copy link
Member

@geido geido commented Apr 5, 2021

SUMMARY

Adds the tests for the Dashboard FilterBar CascadeFilterControl component.

TEST PLAN

All tests should pass

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas
Copy link
Member

rusackas commented Apr 5, 2021

@geido this appears to just need a lil' rebase, and then I'm happy to merge.

@junlincc junlincc added need:merge The PR is ready to be merged and removed need:merge The PR is ready to be merged labels Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #13950 (2c648a2) into master (8b9c142) will increase coverage by 0.69%.
The diff coverage is 100.00%.

❗ Current head 2c648a2 differs from pull request most recent head c651072. Consider uploading reports for the commit c651072 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13950      +/-   ##
==========================================
+ Coverage   77.87%   78.57%   +0.69%     
==========================================
  Files         935      935              
  Lines       47375    47375              
  Branches     5964     5964              
==========================================
+ Hits        36895    37224     +329     
+ Misses      10323    10007     -316     
+ Partials      157      144      -13     
Flag Coverage Δ
cypress 56.03% <ø> (+5.27%) ⬆️
javascript 67.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rBar/CascadeFilters/CascadeFilterControl/index.tsx 85.71% <100.00%> (ø)
.../FilterBar/CascadeFilters/CascadePopover/index.tsx 83.09% <100.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 63.26% <0.00%> (+0.20%) ⬆️
.../src/explore/components/ControlPanelsContainer.tsx 97.34% <0.00%> (+0.88%) ⬆️
...nd/src/explore/components/ExploreViewContainer.jsx 77.77% <0.00%> (+1.16%) ⬆️
...et-frontend/src/components/EditableTitle/index.tsx 75.30% <0.00%> (+1.23%) ⬆️
superset-frontend/src/reduxUtils.ts 81.01% <0.00%> (+1.26%) ⬆️
...ntend/src/explore/components/ExploreChartPanel.jsx 82.60% <0.00%> (+1.44%) ⬆️
superset-frontend/src/chart/Chart.jsx 64.81% <0.00%> (+1.85%) ⬆️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 73.58% <0.00%> (+1.88%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9c142...c651072. Read the comment docs.

@rusackas rusackas merged commit c0888dc into apache:master Apr 6, 2021
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M test:case 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants